Aachen turbine tutorial text and figures#163
Conversation
|
@joshkellyjak, could you please also review this part of the tutorial? |
| ### Background | ||
|
|
||
| This example uses a 3D one and a half turbine stage encompassing one stator, one rotor and a downstream stator, equal to the | ||
| first one. Consequently, the case requires multiple frame of reference to account for the rotor rotation |
There was a problem hiding this comment.
multiples frames of reference
There was a problem hiding this comment.
to account for the rotation of the rotor
There was a problem hiding this comment.
I think this sounds a little more natural?
|
|
||
| #### Non-reflective boundary conditions | ||
| Non-reflective boundary conditions can be enforced by means of the | ||
| ```MARKER_GILES``` boundary. They can be used for both inlet-outlet, as well as mixing-plane boundaries. Furthermore, under-relaxation factors can be provided both for the average and Fourier components at any boundary where the Giles boundary condition is used. |
There was a problem hiding this comment.
I would include a reference to Salvo's paper to detail the non-reflective boundary conditions. It may also be worth mentioning the equation that the relaxation factors are applied to (eq. 2 of the paper) as it has caused some confusion in the past.
There was a problem hiding this comment.
I would include a reference to Salvo's paper to detail the non-reflective boundary conditions. It may also be worth mentioning the equation that the relaxation factors are applied to (eq. 2 of the paper) as it has caused some confusion in the past.
I have introduced the link to the paper without reporting the equation, as I think that would need more detail and context to be interpreted
There was a problem hiding this comment.
Hmm I guess that it would maybe go a bit beyond the level of an introductory tutorial. I also can't read so missed the reference 😅
|
You also need to add a reference to _data/tutorials.yml so it is added to the list of tutorials. The name that you add should correspond to the folder/markdown filename, so Aachen_Turbine. |
Thank you for the suggestion, Nijso! I added it. |
|
LGTM! |
3 participants
No description provided.